Page refreshes: Replace remaining calls to nextAnimationFrame by nextRepaint #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that page refreshes work properly when the page is in the background.
|
Thanks @brunoprietog! |
domchristie
pushed a commit
to domchristie/turbo
that referenced
this pull request
Jul 20, 2024
…d#1102) This ensures that page refreshes work properly when the page is in the background.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1042,
nextRepaintutil was created, which only callsnextAnimationFramewhen the page is in the foreground, and when it is in the background it callsnextEventLoopTick. Then,nextAnimationFramewas replaced in theStreamElementrendermethod to allow Turbo streams actions to run even if the page is in the background.Now that a page refresh can also be triggered by Turbo streams, it is necessary to change the remaining calls to
nextAnimationFrame, so that page refreshes and Turbo frame reloads can occur in the background as well.So, this change ensures that page refreshes work properly when the page is in the background.