Try to fix progress bar persisting when following a redirect #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intrepidd
force-pushed
the
fix-progress-bar-on-redirect
branch
from
e9bd02d
to
c83f8ee
Compare
Intrepidd
force-pushed
the
fix-progress-bar-on-redirect
branch
from
c83f8ee
to
3ad4134
Compare
|
Looks good to me 👍 @seanpdoyle what do you think? |
|
Does this impact any of these open issues? |
seanpdoyle
approved these changes
Feb 7, 2024
|
@Intrepidd I've cut 8.0.1 including this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since cc263b4, it looks like the turbo progress bar will stick around when visiting a page that redirects to another one.
To resolve another issue, the hiding of the progress bar has been moved from
visitRequestFinishedtovisitCompleted.However, the
visitCompletedevent is not called on the browser adapter when the visit followed a redirect. This PR challenges this behaviour.I added a regression test as well.