Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that page refreshes do not trigger a snapshot cache #1196

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Ensure that page refreshes do not trigger a snapshot cache #1196

merged 1 commit into from
Feb 21, 2024

Commits on Feb 21, 2024

  1. Ensure that page refreshes do not trigger a snapshot cache 

    Fixes a bug introduced in #1146

`exemptPageFromPreview()` adds a `<meta>` tag to the `<head>` setting
`turbo-cache-control` to `no-preview`. However, since the MorphRenderer
now inherits from the PageRenderer, it can update meta tags in the head
and remove the `turbo-cache-control` tag. This means that the snapshot
cache will be used for the next visit, which is not what we want.

Specifying `shouldCacheSnapshot: false` in the `visit` options ensures
that the snapshot cache is not used for the refresh visit.
    @afcapel
    afcapel committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    53537c0 View commit details
    Browse the repository at this point in the history