-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(markdown): support codespell #229
Conversation
I'm unsure what it's supposed to achieve. I know codespell very well. It might suggest multiple solutions to fix a typo. So -w won't fix it. You will have to fix it manually, and it will return an non-zero exist code, which may be interpreted wrongly by your tool You might have to use |
Adding support for spellcheckers seemed like a nobrainer since this tool is focused on documentation already. You are right that it shouldn't autofix in case of wrong suggestions. |
My point was also about your code should catch the errors code and report the errors or a message. But I agree it's a great addition |
I must have misunderstood what you meant by
|
My point was that codespell and typos could recommend multiple words for the same typo Like for "thn", they might suggest
I saw you rolled back, so it's great. My concern was the fact than when they are alternative that cannot be fixed. typos or codespell will return a non-zero code, so you will receive it as if the tool was in error. So you might be aware of it and handle these use cases by reporting these warnings. |
No description provided.