Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: creating new SMC ami charts #640

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

YazeedLoonat
Copy link
Collaborator

Issue Overview

This PR addresses #issue

  • This change addresses the issue in full

Description

This creates 2 new ami charts for smc outlined in attached issue

I also created a new script (heavily based on the existing one) that is closer.

I think once we switch to prisma adding a new migration to do this each time will be difficult so the new script still allows for migrations, but is closer to what the openapi docs page would also want to accept

Also we now have some examples of what the input/output of the script is

How Can This Be Tested/Reviewed?

Run the migration locally and you should see the 2 new ami charts get created.
these new charts should be selectable when adding units to a listing

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for housing-sanjoseca-gov ready!

Name Link
🔨 Latest commit c2f2de4
🔍 Latest deploy log https://app.netlify.com/sites/housing-sanjoseca-gov/deploys/64f0fefb0cca9e000874939a
😎 Deploy Preview https://deploy-preview-640--housing-sanjoseca-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ludtkemorgan
Copy link
Collaborator

@YazeedLoonat I think if you push up a new commit the netlify should pass. I retriggered the netlify job and it passed, but github didn't pick it up

@ludtkemorgan ludtkemorgan merged commit a54bead into main Aug 31, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants