Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publishedAt on create (#4479) #812

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ColinBuyck
Copy link
Collaborator

This PR addresses #773

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

During Qa, it was discovered that the publishedAt date was showing as none for many open listings. This was because we were not covering the case where a user publishes a listing from scratch, never first saving it as a draft.

How Can This Be Tested/Reviewed?

Create a listing from scratch and publish it without saving it as a draft. In the partner's listing table, you should see today's date.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@ColinBuyck ColinBuyck added 1 review needed release A PR that is pulling over a commit(s) from core labels Nov 19, 2024
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for housing-sanjoseca-gov ready!

Name Link
🔨 Latest commit b00dd4f
🔍 Latest deploy log https://app.netlify.com/sites/housing-sanjoseca-gov/deploys/673d084e1332eb0008daca3c
😎 Deploy Preview https://deploy-preview-812--housing-sanjoseca-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge release A PR that is pulling over a commit(s) from core
Development

Successfully merging this pull request may close these issues.

2 participants