0.98 php8 deprecation fixes and small improvements #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update jQuery to latest version 3.6.0.
Replace it with own function to keep backward compatibility with existing configuration.
It's deprecated in PHP 8.0
* Make object properties dialog bigger
Fix it via array_splice().
Fix: PHP Fatal error: Uncaught TypeError: Unsupported operand types: string / int in /data/noc/weathermap/lib/WeatherMap.functions.php:1780
…e icon/image locations.
Creation of dynamic property WeatherMap::* is deprecated Creation of dynamic property WeatherMapNode::* is deprecated Creation of dynamic property WeatherMapDataSource_fping::* is deprecated Creation of dynamic property WeatherMapDataSource_snmp::* is deprecated Creation of dynamic property WeatherMapDataSource_snmp2c::* is deprecated
PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /data/noc/weathermap/lib/datasources/WeatherMapDataSource_mrtg.php
Fix one more deprecation warning. Make it possible to edit quoted strings in editor.
…use them in special tokens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly there are fixes for deprecated functions in PHP 8.X.
Except that there are some improvements in Special Tokens processing, added possibility to edit quoted values in editor (for example, parameters in TARGET which contain spaces), added simple rrdtool binary path detection, incomment/outcomment now can be referenced in Special Tokens, etc.