Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Change 500 to 404 when team not found #1548

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Conversation

krashidov
Copy link
Contributor

  • We recently had an Enterprise Grid customer sign up. Somehow, we're receiving webhook events from teams that are part of their grid that haven't signed up yet and thus are not in our database. This has blown up our errors and now we're getting hundreds of emails a day.
  • Please note that I originally changed these from simple return statements (that would eventually timeout) to 500 status codes. So I'm just doing what I should've done in the first place :)

@benbrown
Copy link
Contributor

Does this have an effect on Slack? Does Slack stop sending the messages for that team?

@benbrown benbrown self-assigned this Dec 19, 2018
@krashidov
Copy link
Contributor Author

No, it's more of this is the correct code we should be sending. We're on heroku and when we send 500's it's sending us emails thinking our server is on fire. When really it's just not finding a team.

@benbrown benbrown merged commit e768f59 into howdyai:master Dec 20, 2018
@benbrown
Copy link
Contributor

Thanks! Merged, and will be in 0.7.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants