Fix channelData replace in conversations

[ashitikov]

#1925 introduced new bug:
When I'm trying to use channelData: { ephemeral: true } with dynamic blocks I get an empty ephemeral message in slack because channelData completely replaces instead of correct copying keys and values with template rendering.

[benbrown]

can you give me more information on how to reproduce this issue?

[ashitikov]

can you give me more information on how to reproduce this issue?

Hi! If you have a dialog
const dialog = new BotkitConversation('SOME_ID', controller);
Then you can add a question to this conversation:

dialog.addQuestion({
    text: 'How are you?',
    channelData: {
        ephemeral: true
    },
    blocks: async (template, vars) => {
        return [...some blocks...]
    }
});

As a developer I'm waiting that this question 'How are you?' will be ephemeral (only visible to that user) with blocks, but in fact this message does not contain any blocks, but becomes ephemeral.

Commenting out channelData { ephemeral: true } makes message not ephemeral, but blocks are visible as it should.

[benbrown]

ah i see, thank you for the info.

[ashitikov]

ah i see, thank you for the info.

Any progress on that? :)

[benbrown]

Sorry for the long wait. Thank you for this fix.