Add flexibility to Slack auth flow via custom redirect params

[sundeepgupta]

#329

This will enable handling auth flows for various use cases by way of redirect_uri query params.

If we stay with the existing design, I see two approaches:
a) Pass params around and only use them if the Slack App controller is configured with the redirectUri value.
b) Pass the entire redirect URI around. This options gives more flexibility in case apps want to have multiple redirect URI endpoints. This might be useful if they want greater control over their auth flows than what Botkit provides.

For the app we're building, we don't have a use case for b), so I thought to try out a) and get some feedback.

Question (if the approach is ok):
Should the redirect_params be passed into the create/update_team and create_bot events also?

[sundeepgupta]

bump, I welcome any comments/questions. Or better yet, a merge if this is good as is :)

[sundeepgupta]

Hey Botkit folks, I welcome any comments/feedback on this. We're using this (via our fork) quite successfully so far.

[anonrig]

missing ;

[sundeepgupta]

@anonrig Great thanks for explaining. I've updated the branch to address the feedback.

[sundeepgupta]

@anonrig quick bump to see if anything else was needed. I think I've addressed everything, but otherwise, please let me know... thanks.

[peterswimm]

@sundeepgupta sorry for the delay, we'll get on evaluating this and other pending PRs very shortly.

[sundeepgupta]

Awesome thanks!

Cheers,
Sundeep

On Aug 29, 2016, at 11:19 AM, Peter Swimm notifications@github.com wrote:

@sundeepgupta https://github.com/sundeepgupta sorry for the delay, we'll get on evaluating this and other pending PRs very shortly.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #343 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ACQWbZqS6gzP1Lq4zhQghDb3vMOZDJtKks5qkvhrgaJpZM4JUPXY.

[sundeepgupta]

Thought I'd give this another bump...

[sundeepgupta]

:nudge:

[josephfinlayson]

Please merge!

[benbrown]

AT LONG LAST, merged!

Thanks for your patience, @sundeepgupta

[sundeepgupta]

yay!