This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Remove integer port requirement for Facebook #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PaaS hosting offerings like Heroku and Azure App Service do not have a standard numerical port, as it's randomly generated when the app is re-started.
The code currently has a check that ensures the port specified is a number. This will always fail and throw an exception on Heroku and Azure App Service, causing the app the crash.
Example port from Azure App Service: ".\pipe\a59322f5-0005-4a3b-9242-24625191a3f2"
My fix removes the number check as ExpressJS, which is how the bots are served, has no requirement that ports are a number.
Closes #369