This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
Fix data race on kevent buffer. #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the BSD implementation of fsnotify, the watcher's kbuf buffers a kevent between syscall.SetKevent (which prepares the kevent) and syscall.Kevent (which registers the kevent). The implementation intends to protect access to kbuf, but fails to do so in addWatch and removeWatch. This change fixes the data race by allocating a new kevent buffer for every method invocation.
|
@tilaks Thanks for the contribution. Please be sure to sign the CLA https://developers.google.com/open-source/cla/individual?csw=1 Would you be willing to send this patch to go.exp/fsnotify? https://code.google.com/p/go/source/browse?repo=exp#hg%2Ffsnotify Otherwise I can upload it on your behalf. |
|
@nathany thanks, submitted a change for review at https://codereview.appspot.com/103300045 |
|
Thanks @tilaks. I haven't had a chance to try out the change, but I'll make some time for that. Someone else will need to submit (merge) the change. |
howeyc
added a commit
that referenced
this pull request
Jun 17, 2014
Fix data race on kevent buffer. Not sure why a mutex doesn't work, but this fix will work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the BSD implementation of fsnotify, the watcher's kbuf buffers a kevent
between syscall.SetKevent (which prepares the kevent) and syscall.Kevent
(which registers the kevent). The implementation intends to protect access to
kbuf, but fails to do so in addWatch and removeWatch.
This change fixes the data race by allocating a new kevent buffer for every
method invocation.