Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "edge" releases #176

Merged
merged 3 commits into from
Oct 19, 2017
Merged

Conversation

carolynvs
Copy link
Collaborator

Fixes #169, so that dvm install edge works. It lists the contents of https://download.docker.com/OS/static/edge/ARCH/ and installs the latest version.

I've renamed from experimental to edge because that's what Docker calls these builds now. This is a breaking change but since it hasn't been working for months (because docker stopped releasing to the old static url), it's already broken.

Docker doesn’t use the term experimental anymore, all the cool kids
call them “edge” releases
Copy link
Member

@rgbkrk rgbkrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, is this ready?

@carolynvs
Copy link
Collaborator Author

Honestly, I don't remember why I didn't merge this! 😊 Let me review, I have more changes upcoming to fix ls-remote, and with so much broken, I need to remind myself why I held off.

@carolynvs
Copy link
Collaborator Author

I can't see any problem that would have caused me to not just merge this, so since @rgbkrk says it's 🏅, I'm good.

@carolynvs carolynvs merged commit ca8c06c into howtowhale:master Oct 19, 2017
@carolynvs carolynvs deleted the experimental branch October 19, 2017 20:38
@rgbkrk
Copy link
Member

rgbkrk commented Oct 19, 2017

Seemed like a good thing to review. I still watch the repo even though I'm not really involved. 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants