Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add github action flow #197

Merged
merged 7 commits into from
Mar 9, 2022
Merged

ci: add github action flow #197

merged 7 commits into from
Mar 9, 2022

Conversation

chenrui333
Copy link
Contributor

No description provided.

Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 marked this pull request as ready for review March 8, 2022 21:56
@chenrui333
Copy link
Contributor Author

cc @carolynvs this PR is ready to go.

@chenrui333
Copy link
Contributor Author

The workflow got tested out in here, https://github.com/chenrui333/dvm/actions

Copy link
Collaborator

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this to gh actions and adding support for more architectures!

@carolynvs carolynvs merged commit 379a780 into howtowhale:main Mar 9, 2022
@chenrui333
Copy link
Contributor Author

This is what drives me in here. :)

@chenrui333
Copy link
Contributor Author

@carolynvs can you also make a quick new release upon this merge. Many thanks!

@chenrui333 chenrui333 deleted the github-action branch March 9, 2022 16:47
@carolynvs
Copy link
Collaborator

Thanks again for the fix! I've published a 1.0.3

@chenrui333
Copy link
Contributor Author

Nice!

@chenrui333
Copy link
Contributor Author

🤔 somehow, I did not see it in here, https://github.com/howtowhale/dvm/releases

@carolynvs
Copy link
Collaborator

Sorry I accidentally tagged it as v1.0.3, when it should be 1.0.3. Fixing now should take 5 minutes. I'm also working on fixing the homebrew formula

@carolynvs
Copy link
Collaborator

Okay try now

@carolynvs
Copy link
Collaborator

Here's the homebrew pr Homebrew/homebrew-core#96598

@carolynvs
Copy link
Collaborator

Okay 1.0.3 with arm support should now be up on homebrew. If it doesn't work, please let me know! I don't have a m1 to test on.

@chenrui333
Copy link
Contributor Author

works for me, thanks!

$ /opt/homebrew/Cellar/dvm/1.0.3/dvm-helper/dvm-helper list-remote
1.8.0
1.8.1
1.8.2
1.8.3
1.9.0
1.9.1
1.10.0
1.10.1
1.10.2
1.10.3
1.11.0
1.8.0
1.8.1
1.8.2
1.8.3
1.9.0
1.9.1
1.10.0
1.10.1
1.10.2
1.10.3
1.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants