Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Euclidean distance should be squared? #6

Closed
ya103 opened this issue Feb 11, 2019 · 3 comments
Closed

Euclidean distance should be squared? #6

ya103 opened this issue Feb 11, 2019 · 3 comments
Assignees
@hoxo-m

Comments

@ya103
Copy link

ya103 commented Feb 11, 2019

densratio/R/compute_kernel_Gaussian.R

Line 10 in 3b877d5

exp(- euclid_distance(x, y) / (2 * sigma * sigma))

This line probably computes the Gaussian kernel.
If so, I think the Euclidean distance should be squared.
@hoxo-m hoxo-m self-assigned this Feb 11, 2019
@hoxo-m
Copy link
Owner

hoxo-m commented May 8, 2019

Yes, you are right.
You have found a big mistake that affects all the algorithms in this package.
Thank you for your big contribution.

hoxo-m added a commit that referenced this issue May 8, 2019
@hoxo-m
Modify Euclidean distance to square Euclidean distance in the functio…
d82aae1 
…n that computes Gaussian kernel (#6).
@hoxo-m
Copy link
Owner

hoxo-m commented May 8, 2019

Fixed in release 0.1.0
https://github.com/hoxo-m/densratio/releases/tag/v0.1.0

@hoxo-m
Copy link
Owner

hoxo-m commented May 9, 2019

It is now on CRAN.
https://cran.r-project.org/package=densratio

@hoxo-m hoxo-m closed this as completed May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoxo-m hoxo-m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hoxo-m @ya103