forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Libraries/DevToolsSettings -> private/reactdevtools/ReactDevToolsSett…
…ings (facebook#46662) Summary: Pull Request resolved: facebook#46662 # Changelog: [Internal] This should not have been a public API in the first place. 1. Moving this to `src/private`. 2. Removed some unused APIs, such as profiling settings. Reviewed By: huntie Differential Revision: D62965492
- Loading branch information
1 parent
98d1ae8
commit 628368d
Showing
15 changed files
with
112 additions
and
212 deletions.
There are no files selected for viewing
35 changes: 0 additions & 35 deletions
35
packages/react-native/Libraries/DevToolsSettings/DevToolsSettingsManager.android.js
This file was deleted.
Oops, something went wrong.
20 changes: 0 additions & 20 deletions
20
packages/react-native/Libraries/DevToolsSettings/DevToolsSettingsManager.d.ts
This file was deleted.
Oops, something went wrong.
49 changes: 0 additions & 49 deletions
49
packages/react-native/Libraries/DevToolsSettings/DevToolsSettingsManager.ios.js
This file was deleted.
Oops, something went wrong.
19 changes: 0 additions & 19 deletions
19
packages/react-native/Libraries/DevToolsSettings/DevToolsSettingsManager.js.flow
This file was deleted.
Oops, something went wrong.
13 changes: 0 additions & 13 deletions
13
packages/react-native/Libraries/DevToolsSettings/NativeDevToolsSettingsManager.js
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 0 additions & 40 deletions
40
...rc/main/java/com/facebook/react/modules/devtoolssettings/DevToolsSettingsManagerModule.kt
This file was deleted.
Oops, something went wrong.
33 changes: 33 additions & 0 deletions
33
...in/java/com/facebook/react/modules/reactdevtoolssettings/DevToolsSettingsManagerModule.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/* | ||
* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
package com.facebook.react.modules.reactdevtoolssettings | ||
|
||
import android.content.Context | ||
import android.content.SharedPreferences | ||
import com.facebook.fbreact.specs.NativeReactDevToolsSettingsManagerSpec | ||
import com.facebook.react.bridge.ReactApplicationContext | ||
import com.facebook.react.module.annotations.ReactModule | ||
|
||
@ReactModule(name = NativeReactDevToolsSettingsManagerSpec.NAME) | ||
public class ReactDevToolsSettingsManagerModule(reactContext: ReactApplicationContext) : | ||
NativeReactDevToolsSettingsManagerSpec(reactContext) { | ||
|
||
private val sharedPreferences: SharedPreferences = | ||
reactContext.getSharedPreferences(SHARED_PREFERENCES_PREFIX, Context.MODE_PRIVATE) | ||
|
||
public override fun setGlobalHookSettings(settings: String): Unit = | ||
sharedPreferences.edit().putString(KEY_HOOK_SETTINGS, settings).apply() | ||
|
||
public override fun getGlobalHookSettings(): String? = | ||
sharedPreferences.getString(KEY_HOOK_SETTINGS, null) | ||
|
||
private companion object { | ||
private const val SHARED_PREFERENCES_PREFIX = "ReactNative__DevToolsSettings" | ||
private const val KEY_HOOK_SETTINGS = "HookSettings" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
packages/react-native/src/private/reactdevtools/ReactDevToolsSettingsManager.android.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/** | ||
* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
* @flow strict-local | ||
* @format | ||
*/ | ||
|
||
import NativeReactDevToolsSettingsManager from '../specs/modules/NativeReactDevToolsSettingsManager'; | ||
|
||
module.exports = { | ||
setGlobalHookSettings(settings: string) { | ||
NativeReactDevToolsSettingsManager?.setGlobalHookSettings(settings); | ||
}, | ||
getGlobalHookSettings(): ?string { | ||
return NativeReactDevToolsSettingsManager?.getGlobalHookSettings(); | ||
}, | ||
}; |
30 changes: 30 additions & 0 deletions
30
packages/react-native/src/private/reactdevtools/ReactDevToolsSettingsManager.ios.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/** | ||
* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
* @flow strict-local | ||
* @format | ||
*/ | ||
|
||
import Settings from '../../../Libraries/Settings/Settings'; | ||
|
||
const GLOBAL_HOOK_SETTINGS = 'ReactDevTools::HookSettings'; | ||
|
||
const ReactDevToolsSettingsManager = { | ||
setGlobalHookSettings(settings: string): void { | ||
Settings.set({ | ||
[GLOBAL_HOOK_SETTINGS]: settings, | ||
}); | ||
}, | ||
getGlobalHookSettings(): ?string { | ||
const value = Settings.get(GLOBAL_HOOK_SETTINGS); | ||
if (typeof value === 'string') { | ||
return value; | ||
} | ||
return null; | ||
}, | ||
}; | ||
|
||
module.exports = ReactDevToolsSettingsManager; |
16 changes: 16 additions & 0 deletions
16
packages/react-native/src/private/reactdevtools/ReactDevToolsSettingsManager.js.flow
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
/** | ||
* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
* @flow strict-local | ||
* @format | ||
*/ | ||
|
||
declare const ReactDevToolsSettingsManager: { | ||
setGlobalHookSettings(settings: string): void, | ||
getGlobalHookSettings(): ?string, | ||
}; | ||
|
||
module.exports = ReactDevToolsSettingsManager; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters