FuseboxTracer: fix internal and oss tests

Summary: # Changelog: [Internal] Differential Revision: D58586169
hoxyq · Jun 14, 2024 · b06a1ef · b06a1ef
1 parent 39774fd
commit b06a1ef
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 10 deletions.
diff --git a/packages/react-native/ReactCommon/jsinspector-modern/CMakeLists.txt b/packages/react-native/ReactCommon/jsinspector-modern/CMakeLists.txt
@@ -23,4 +23,5 @@ target_link_libraries(jsinspector
         glog
         react_featureflags
         runtimeexecutor
+        reactperflogger
 )
diff --git a/packages/react-native/ReactCommon/reactperflogger/CMakeLists.txt b/packages/react-native/ReactCommon/reactperflogger/CMakeLists.txt
@@ -13,7 +13,9 @@ add_compile_options(
         -Wall
         -Wpedantic)
 
-file(GLOB reactperflogger_SRC CONFIGURE_DEPENDS reactperflogger/*.cpp)
+file(GLOB reactperflogger_SRC CONFIGURE_DEPENDS
+        reactperflogger/*.cpp
+        reactperflogger/fusebox/*.cpp)
 add_library(reactperflogger STATIC ${reactperflogger_SRC})
 
 target_include_directories(reactperflogger PUBLIC .)
diff --git a/packages/react-native/ReactCommon/reactperflogger/fusebox/tests/FuseboxTracerTest.cpp b/packages/react-native/ReactCommon/reactperflogger/fusebox/tests/FuseboxTracerTest.cpp
@@ -9,15 +9,9 @@
 
 #include "reactperflogger/FuseboxTracer.h"
 
-folly::dynamic stopTracingAndCollect() {
-  folly::dynamic trace = folly::dynamic::array;
-  FuseboxTracer::stopTracing([&trace](const folly::dynamic& eventsChunk) {
-    for (const auto& event : eventsChunk) {
-      trace.push_back(event);
-    }
-  });
-  return trace;
-}
+namespace facebook::react {
+
+namespace {
 
 class FuseboxTracerTest : public ::testing::Test {
  protected:
@@ -32,8 +26,20 @@ class FuseboxTracerTest : public ::testing::Test {
   void TearDown() override {
     stopTracingAndCollect();
   }
+
+  folly::dynamic stopTracingAndCollect() {
+    folly::dynamic trace = folly::dynamic::array;
+    FuseboxTracer::stopTracing([&trace](const folly::dynamic& eventsChunk) {
+      for (const auto& event : eventsChunk) {
+        trace.push_back(event);
+      }
+    });
+    return trace;
+  }
 };
 
+} // namespace
+
 TEST_F(FuseboxTracerTest, TracingOffByDefault) {
   EXPECT_FALSE(FuseboxTracer::isTracing());
 }
@@ -70,3 +76,5 @@ TEST_F(FuseboxTracerTest, MultiEvents) {
   EXPECT_GE(stopTracingAndCollect().size(), 10);
   EXPECT_EQ(stopTracingAndCollect().size(), 0);
 }
+
+} // namespace facebook::react