[WIP] Feature Powerlimiter #108
Conversation
Some values could not be deserialized and where null
…ments * The voltage load correction factor now takes the voltage drop under load into account to not stop the producer too early already * Fix powerlimiter interval not being set * Set the power limit to the lowest value when the producer is stopped * Other smaller improvements
If Victron support is enabled, the Dynamic Power Limiter will now directly pass through all power coming from the Victron MPTT to the grid. This is better for the battery, as it prevents the battery from being charged unnecessarily. It also decreases unnecessary energy loses.
* Add translations for en and de for Powerlimiter & Battery admin settings * Add SOC thresholds to Powerlimiter
| @@ -35,6 +47,14 @@ void MqttSettingsClass::onMqttConnect(bool sessionPresent) | |||
| for (const auto& cb : _mqttSubscribeParser.get_callbacks()) { | |||
| mqttClient->subscribe(cb.topic.c_str(), cb.qos); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This is not used and callbacks point to 0. I would remove all changes to this file.
There was a problem hiding this comment.
This is not coming from my branch. Maybe a rebase problem? I don't have access to my IDE at the moment. When I've time, I'll do one more merge or rebase and make sure that everything is correct.
| return; | ||
| } | ||
|
|
||
| float dcVoltage = inverter->Statistics()->getChannelFieldValue(CH1, FLD_UDC); |
There was a problem hiding this comment.
must be
float dcVoltage = inverter->Statistics()->getChannelFieldValue(TYPE_DC, CH1, FLD_UDC);
| } | ||
|
|
||
| if (inverter->isProducing()) { | ||
| float acPower = inverter->Statistics()->getChannelFieldValue(CH0, FLD_PAC); |
There was a problem hiding this comment.
Must be
float acPower = inverter->Statistics()->getChannelFieldValue(TYPE_AC, CH0, FLD_PAC);
|
May be it make sense to accept my PR #102 before this will be integrated into development branch? |
|
You can just change the target branch of your PR to development and I'll also continue working in the powerlimiter branch after the first merge, so there is no need to hurry for you :) |
|
@berni2288 I merged your power_limiter branch to develop. It's working fine. So I propose you create a new feature branch from development for further power_limiter changes. |
|
Thanks! I can create a branch for each pull request from now on. |
|
Closing this PR since the branch already got merged to "development" manually. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Todo: Write list of features & changes here.