Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit for MQTT battery voltage #1143

Conversation

vaterlangen
Copy link

@vaterlangen vaterlangen commented Jul 30, 2024

Implemented the - at least for my setup - missing unit for battery voltage received via MQTT. It compiles locally , but could not test WebUI integration. and was successfully tested on my Fusion board

@vaterlangen vaterlangen changed the title Added unit for MQTT batter voltage Added unit for MQTT battery voltage Jul 30, 2024
@schlimmchen
Copy link
Member

Very nice, thank you! Do you believe that anybody would transport dV or cV over MQTT? I think those units are not needed. In other places we also only provide Milli or Kilo of a unit.

@vaterlangen
Copy link
Author

vaterlangen commented Jul 31, 2024

Unfortunately, yes. Zendure Solarflow is publishing cV (at least if uncoupled from vendor cloud).
I'm currently using the cV setting - the dV was only added for completeness.

@schlimmchen
Copy link
Member

Oh, indeed, you already posted your example in the other PR. Well, then I agree that adding dV as well makes sense for completeness. I guess we won't need kV 😁

I guess we need to explain this somewhere, as cV and dV are quite exotic. @Manos1966 Do you know a good place in the wiki to add an explanation, maybe an example of when to use dV or cV or mV?

Also, I see that you created this PR against the other PR, very nice!

Thanks again ❤️

@schlimmchen schlimmchen merged commit 48bfa7c into hoylabs:mqtt-battery-json-parsing Jul 31, 2024
8 checks passed
@Manos1966
Copy link

Hallo @schlimmchen

ich glaube wir haben heute keine mV Anzeige auf unserem WebUI...
Ueber RS485 habe ich die Spannungsdifferenz der Batterie Zellen in mV, aber das haben wir ueber CANbus nicht.

centiVolts habe ich seit der Zeit der Uni nicht wieder gesehen 🙈

Habt Ihr vielleicht ein Beispiel eines Geraets, dass solche Daten liefert?

@Manos1966
Copy link

Oh, ich habe gerade gesehen, die Erklärungen sind bereits im Code.
Es wird also eine Option zum auswählen!

enum BatteryVoltageUnit { Volts = 0, DeciVolts = 1, CentiVolts = 2, MilliVolts = 3 }

Dann schlage ich vor: Ich warte bis die Release verteilt wird, mache ein Screenshot der Option und addiere ich mit entsprechende Erklärung im relevanten Bereich.

@AndreasBoehm
Copy link
Member

ich glaube wir haben heute keine mV Anzeige auf unserem WebUI... Ueber RS485 habe ich die Spannungsdifferenz der Batterie Zellen in mV, aber das haben wir ueber CANbus nicht.

centiVolts habe ich seit der Zeit der Uni nicht wieder gesehen 🙈

Habt Ihr vielleicht ein Beispiel eines Geraets, dass solche Daten liefert?

Die Spannungsdiferenz der Batterie Zellen einer Pytes Batterie (verbunden über CAN0 wird in mV im WebUI angezeigt
image

@Manos1966
Copy link

Copy link

github-actions bot commented Sep 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants