Allow for defining only rx pin for VE.direct

[philippsandhaus]

This PR removes the necessity for defining a GPIO Pin for tx for Victron devices. Currently sending commands is not done and thus only the rx pin is used for MPPT and SmartShunt devices.

I thought about removing the victron_tx part completely in the code, but I think it will make potential future support for sending commands to the victron devices easier, but the tx pin should not be mandatory at the moment.

I think, this would eliminate a lot of confusion, what do you think?

[schlimmchen]

Nice. Good idea.

[I was about to say that there is a whitespace before the closing bracket of the if statement that you changed, but none at the start, but I will exercise myself in restraint 😁]

Please update the Wiki accordingly, i.e., mention that the TX pin is optional. Are there more places where docs have to be updated?

[philippsandhaus]

whitespace removed ;-)

It is not directly mentioned in the Wiki, only that a physical connection is not needed. But I think it would make sense to describe how to define the GPIO pins and then mention that tx is optional. I can update the Wiki but would do this after the PR is in master and in the latest release. I don't see that this is mentioned elsewhere in the docs.

[schlimmchen]

The VE.Direct Wiki page now mentions that one can leave Victron RX pin unconnected and set pin mapping TX pin to -1 accordingly. This is in anticipation that this PR is merged eventually.

The device profile wiki page should still be updated.

[philippsandhaus]

Thank you, I just did an update of the Device Profiles page.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.