Enable IME native backend with mdtest #133
Conversation
This patch adds the support of statfs in the IME backend. It uses ime_native_statvfs call to fill the ior_aiori_statfs_t structure.
src/mdtest.c
Outdated
| if (strcasecmp(backend_name, "POSIX") != 0 && strcasecmp(backend_name, "DUMMY") != 0) { | ||
| if ((strcasecmp(backend_name, "POSIX") != 0) && | ||
| (strcasecmp(backend_name, "IME") != 0) && | ||
| (strcasecmp(backend_name, "DUMMY") != 0)) { | ||
| FAIL("-a only supported interface is POSIX (and DUMMY) right now!"); |
There was a problem hiding this comment.
Can you update the error message to include IME?
There was a problem hiding this comment.
Sure I'll resubmit a version. Thanks for the review!
|
Thanks for contributing this! The changes seem very well encapsulated. I don't know if we have a way to test this independently, but it looks like it won't really affect non-IME functionality at all. The error message should perhaps be updated, or maybe only updated if compiled with IME enabled. Happy to hear opinions from others on this. |
|
Yes we have a way to test this independently. We made a mock interface which fakes a IME client and does POSIX calls. I'll do another PR to incude this in the Travis tests. |
This patch makes mdtest allow IME native interface. It also defines a generic way to enable mdtest with each backend.
|
Hi, could you tell me if you see other stuff I could improve for those 2 patches? |
| } ior_aiori_t; | ||
|
|
||
| enum bench_type { |
There was a problem hiding this comment.
I find this solution a bit crude. AIORI at some point might become a library and useful to other benchmarks. But well, Ok for now.
No description provided.