Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial.rst #151

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Update tutorial.rst #151

merged 1 commit into from
Oct 2, 2019

Conversation

haplav
Copy link
Contributor

@haplav haplav commented May 16, 2019

"Defeating Page Cache" should be a heading I guess.

"Defeating Page Cache" should be a heading I guess.
@JulianKunkel
Copy link
Collaborator

JulianKunkel commented May 16, 2019 via email

@glennklockwood
Copy link
Contributor

I actually have a branch with significant edits to the documentation (https://github.com/glennklockwood/ior/tree/docfixes), but it is now out of sync with the current master. I can rebase it and try to update the documentation as best I can, but it will need help from the community to spot places where new features haven't been captured.

@haplav
Copy link
Contributor Author

haplav commented May 16, 2019

thanks for contributing, any more thoughts on documntation, maybe? Am Do., 16. Mai 2019 um 19:51 Uhr schrieb Vaclav Hapla notifications@github.com:

If I find something again, I will get back to you. But dor now I would just propose to put the link to https://ior.readthedocs.io/en/latest/index.html somewhere clearly to GitHub, probably README.md.

Today I first got to http://wiki.lustre.org/IOR where I spent some time before I noticed it was completely outdated and the mentioned GitHub repository archived. Then got to this GitHub repo where I found doc/USER_GUIDE. And only now in the evening I noticed the readthedocs docs, only thanks to the issue mentioning it. Please just take it as a hint for improvement.

Anyway, thanks for maintaining this tool.

@glennklockwood
Copy link
Contributor

This is good feedback, and I agree that the documentation is currently all over the place (multiple README files, a manpage, a USER_GUIDE, etc). I'll create an issue so we can track this more closely.

@haplav
Copy link
Contributor Author

haplav commented May 16, 2019

Sounds good!

@haplav
Copy link
Contributor Author

haplav commented May 16, 2019

One more specific comment: It is not clear from docs whether Lustre stripe settings are applied even to a pre-existing file (done by copying it to a temporary file with the that stripe settings). But looking at the source code I don't think so, and in that case it should be explicitly mentioned in docs or implemented as above, I believe.

@glennklockwood glennklockwood merged commit 7f4f4af into hpc:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants