add mknod support #158
Merged
add mknod support #158
+41
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new option '-k' to support file creation test with mknod, which is widely used in lustre. Signed-off-by: Gu Zheng <gzheng@ddn.com>
JulianKunkel
approved these changes
May 23, 2019
| { | ||
| int *fd; | ||
|
|
||
| fd = (int *)malloc(sizeof(int)); |
There was a problem hiding this comment.
This is not optimal, as with Mknod you do not call POSIX_close() which calls free(fd). I will fix this, though in a subsequent patch.
|
Now that I did some further testing, as you create regular files at the moment, these could support "-w" and File_close(). Or do you aim to use it to create special inodes and such? |
|
Hi @JulianKunkel , thanks for your quick review and improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new option '-k' to support file creation test with mknod,
which is widely used in lustre.
Signed-off-by: Gu Zheng gzheng@ddn.com