Feature stonewall perf report #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbent
reviewed
Aug 1, 2019
| fprintf(out_logfile, "%14.3f ", mean); | ||
| fprintf(out_logfile, "%14.3f\n", sd); | ||
| fflush(out_logfile); | ||
| if (i != 2) { |
There was a problem hiding this comment.
This line here 'if (i != 2) {' is hard to read. What is 'i' and what is '2'? This is not really related to your PR but it'd be nice if 'i' had a better variable name and if 2 was an enum or something. Maybe just a comment here to remind the reader what these values are? Then later we should go back I think and give 'i' a more meaningful name. 'i' is useful as the index within a tight loop but here I think it is being used as something else.
|
OK to merge despite the |
|
The line existed before just now outside the if()
Cleanup => next time ^-^
Am Fr., 2. Aug. 2019 um 14:34 Uhr schrieb Glenn K. Lockwood <
notifications@github.com>:
… OK to merge despite the i == 2 bit? I'm OK with kicking the can on this,
as there are way worse offenses in both IOR and mdtest.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#166?email_source=notifications&email_token=ABGW5SULIJ2J5VY2RKOIK7TQCQZVLA5CNFSM4IISV6A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3NYIFQ#issuecomment-517702678>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABGW5SWSB3WQSU7WF76YZBTQCQZVLANCNFSM4IISV6AQ>
.
--
Dr. Julian Kunkel
Lecturer, Department of Computer Science
+44 (0) 118 378 8218
http://www.cs.reading.ac.uk/
https://hps.vi4io.org/
PGP Fingerprint: 1468 1A86 A908 D77E B40F 45D6 2B15 73A5 9D39 A28E
|
|
+1. I don’t think this PR added this. I just noticed it while reading the
PR. :)
…On Fri, Aug 2, 2019 at 10:34 PM Glenn K. Lockwood ***@***.***> wrote:
OK to merge despite the i == 2 bit? I'm OK with kicking the can on this,
as there are way worse offenses in both IOR and mdtest.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#166?email_source=notifications&email_token=AAPT2PVPAPDVYWOP7UAETJ3QCQZVJA5CNFSM4IISV6A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3NYIFQ#issuecomment-517702678>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPT2PT7GVTSB7LHQNY5P53QCQZVJANCNFSM4IISV6AQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MDTest and IOR can output the performance when hitting the stonewall.
Also allow to output rate and tp for mdtest.