Implement Locking System Across Multiple Pavilion Instances #735

hwikle-lanl · 2024-02-05T18:53:39Z

Code review checklist:

Code is generally sensical and well commented
Variable/function names all telegraph their purpose and contents
Functions/classes have useful doc strings
Function arguments are typed
Added/modified unit tests to cover changes.
New features have documentation added to the docs.
New features and backwards compatibility breaks are noted in the RELEASE.md

lib/pavilion/lockfile.py

test/tests/lock_tests.py

lib/pavilion/lockfile.py

Separate different modes of failure into separate try/catch sections, for lockfile creation, and include information about previous errors. Also remove unnecessary cast to list when sorting lockfiles and correct outdated docstring for FuzzyLock __enter__ method.

Hank Wikle and others added 30 commits January 10, 2024 10:08

add notes

ffe4f00

start towards prototype solution

1277263

track build hashes on MultiBuildTracker

5f35168

restore lost changes

353b2cc

fix mistake

d9c8571

implement hash->lock map

f44a8dd

fix lingering misnamed function call

a4e3fa7

remove stray code

992d526

cache build hash on creation

113b552

attempt to resolve style test failure

f72d24b

second attempt at style test

e3e036c

add "fuzzy" lockfile implementation

ba686f2

fix minor style issue

f6d69f6

reimplement timeout on build locks

0af8ad1

update build locking test

7d96487

ignore vscode workspace

6acbf4e

attempt to fix timeout

cb33723

fix timed lock context management

99d60c2

fix style issues; tweak lock context

fad32cf

fix mistake; more style fixes

51d3003

fix changed method name

3b8c3e4

another style fix

1487d4b

even more style fixes

8641ae8

(attempt to) fix broken unit test

6a4716b

fix mistake with protected class

04abb19

fix accidentally deleted import

f14423f

restore removed import

2550e1b

attempt to fix broken docstring

d29b0d1

restore (janky) docstring to pass unit test

0623307

fix unit test

e9d0d42

hwikle-lanl added 4 commits February 9, 2024 10:00

integrate NFSLock into builder and mb_tracker

f3f7d94

progress towards integrating NFSLock object

872a0b1

fix some failing tests

adeefe5

pass test_rebuild test

42bcb99

hwikle-lanl marked this pull request as ready for review February 16, 2024 16:51

hwikle-lanl added 3 commits February 23, 2024 08:57

Merge branch 'master' into fuzzy-lock

45d1178

fix style issues

e685fc0

fix NameError

9752932

Paul-Ferrell reviewed Feb 28, 2024

View reviewed changes

hwikle-lanl added 14 commits March 1, 2024 11:03

implement PR feedback

3483891

fix style issues

cf1a416

remove lockfile directory once empty

15290ce

miscellaneous changes

f26f5a0

remove use of lock timeout in builder

b6ef151

implement code review feedback

0257f21

add tests for fuzzylock

a955a44

return lockfile from __enter__ method

e1519ff

create tests for FuzzyLock

f2b822f

pass fuzzylock mutual exclusion test

a156cea

fix FuzzyLock cleanup test

5dbb32e

fix style issues

f944e3e

remove debug print statements

56621ab

more style fixes

3528ef6

Paul-Ferrell reviewed Mar 20, 2024

View reviewed changes

lib/pavilion/lockfile.py Outdated Show resolved Hide resolved

lib/pavilion/lockfile.py Outdated Show resolved Hide resolved

lib/pavilion/lockfile.py Outdated Show resolved Hide resolved

test/tests/lock_tests.py Show resolved Hide resolved

hwikle-lanl added 2 commits March 22, 2024 11:22

implement code review feedback

d2b81b1

fix failing tests

9313406

Paul-Ferrell reviewed Apr 10, 2024

View reviewed changes

lib/pavilion/lockfile.py Outdated Show resolved Hide resolved

lib/pavilion/lockfile.py Outdated Show resolved Hide resolved

hwikle-lanl and others added 3 commits April 12, 2024 10:18

Implement PR feedback

84f634b

Separate different modes of failure into separate try/catch sections, for lockfile creation, and include information about previous errors. Also remove unnecessary cast to list when sorting lockfiles and correct outdated docstring for FuzzyLock __enter__ method.

Merge branch 'develop' into fuzzy-lock

56e236a

Merge branch 'develop' into fuzzy-lock

a87302f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Locking System Across Multiple Pavilion Instances #735

Implement Locking System Across Multiple Pavilion Instances #735

hwikle-lanl commented Feb 5, 2024

Implement Locking System Across Multiple Pavilion Instances #735

Are you sure you want to change the base?

Implement Locking System Across Multiple Pavilion Instances #735

Conversation

hwikle-lanl commented Feb 5, 2024