New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Nick's Changes #773

Merged

Paul-Ferrell merged 2 commits into develop from spack-flux-integration

Jul 10, 2024

Collaborator

hwikle-lanl commented Jun 18, 2024

Code review checklist:

Code is generally sensical and well commented
Variable/function names all telegraph their purpose and contents
Functions/classes have useful doc strings
Function arguments are typed
Added/modified unit tests to cover changes.
New features have documentation added to the docs.
New features and backwards compatibility breaks are noted in the RELEASE.md

hwikle-lanl added 2 commits

June 18, 2024 13:19


          Progress towards integration

8610a9f


          Pass all unit tests

e3c7fd0

hwikle-lanl requested a review from Paul-Ferrell

June 18, 2024 21:36

hwikle-lanl self-assigned this

Paul-Ferrell approved these changes

View reviewed changes

Paul-Ferrell merged commit df2fcf3 into develop

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet