allow disabling sky signal from the command line #313
Conversation
| ): | ||
| """ Use PySM to simulate smoothed sky signal. | ||
|
|
||
| """ | ||
| if not args.pysm_model: | ||
| if not args.pysm_model or not args.simulate_sky: | ||
| return None |
There was a problem hiding this comment.
As You are modifying this, what about replace return None with return only?
There was a problem hiding this comment.
Explicit is better than implicit (https://www.python.org/dev/peps/pep-0020) especially when the method usually has a return value. Now that you brought this up, I'll go add None to https://github.com/hpc4cmb/toast/blob/sky_signal_args/src/toast/pipeline_tools/sky_signal.py#L252-L255
There was a problem hiding this comment.
Conviqt and PySM args already add these: https://github.com/hpc4cmb/toast/blob/sky_signal_args/src/toast/pipeline_tools/sky_signal.py#L136 and https://github.com/hpc4cmb/toast/blob/sky_signal_args/src/toast/pipeline_tools/sky_signal.py#L245 respectively.
There was a problem hiding this comment.
I agree with the first answer to https://stackoverflow.com/questions/15300550/return-return-none-and-no-return-at-all.
Here we are breaking out of a func so I would use return.
Most pipeline_tools packages allow disabling the module from the command line. This PR adds that functionality to PySM, conviqt and map sampling: regardless of what arguments are specified before, if the user extends the command line with
--no-skyor--no-simulate-sky, then the sky simulation is disabled.