Add github action to run unit tests #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For python 3.5, 3.6, 3.7, and 3.8 pull the appropriate cmbenv:toast-deps
container.
- Install toast into a temporary container based on one of these upstream
images.
- Run the serial and MPI tests in this temporary container, and also test
that the documentation builds with sphinx.
This also removes the entire directory of travis support scripts, which
are no longer needed. An additional workflow can be added later for deploying
to pip wheels.
|
Ok @zonca and @keskitalo , please look at this when you have time. It removes all the travis dependency stuff in favor of using the containers here: https://hub.docker.com/orgs/hpc4cmb/repositories And runs the serial / MPI unit tests and builds the docs directly on github. The workflow status looks like this: https://github.com/hpc4cmb/toast/pull/349/checks?check_run_id=681613869 I think this will be much easier to maintain and extend to deploying docs and pip wheels going forward. |
keskitalo
approved these changes
May 18, 2020
|
Ok, thanks for the feedback, merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the continuous integration service from travis to github actions / workflows. The main benefits are larger allowed resource usage, including a 6 hour run time per job and no need to print things to stdout to keep the job alive like on travis. Also the unit tests on github run faster than on travis.
The units test are also converted to run in pre-built docker containers with all dependencies. These are generated automatically for python 3.5-3.8 whenever a new tag is made of the cmbenv repo:
https://github.com/hpc4cmb/cmbenv/blob/master/.github/workflows/deploy.yml
Hopefully this will streamline the process of updating the testing whenever a dependency is updated.