Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native mapmaker #352

Merged
merged 7 commits into from
Jun 2, 2020
Merged

Use native mapmaker #352

merged 7 commits into from
Jun 2, 2020

Conversation

keskitalo
Copy link
Member

Make the TOAST native mapmaker the default in toast_satellite_sim.py and toast_ground_sim.py. madam can still be invoked with --madam but now the pipelines will run even without it. The TOAST mapmaker is still significantly slower in a head-to-head comparison but it is built to be more generic and will support templates that are not limited to 1/f noise models.

@keskitalo keskitalo requested a review from tskisner June 1, 2020 21:19
Copy link
Member

@tskisner tskisner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the two example pipelines consistent, and for enabling the native mapmaker as the default. This will make benchmarking easier and enable destriping "out of the box" from PyPI packages.

@keskitalo keskitalo merged commit 2c636e4 into master Jun 2, 2020
@keskitalo keskitalo deleted the use_native_mapmaker branch June 2, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants