Check that plan returned by fftw is not null #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because MKL, when pretending to be fftw, cannot perform some transforms.
|
Thanks for this, I just pushed one small bit of extra logging. Do you think we need to be more clever about detecting MKL's FFTW interface? For example, should our top level CMakeLists.txt check for FFTW first (before BLAS/LAPACK) and make sure that our detected FFTW is appended to linking after any MKL for blas/lapack? |
|
Ok, since it was easy, I changed the order of checking / linking FFTW. Hopefully that will help avoid ending up with MKL symbols for FFTW. |
|
Oh, nice... the linking order business is eye-opening. I will give that a try next time... not everyone is as willing as I am to just purge MKL... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because MKL, when pretending to be fftw, cannot perform some transforms.