Implementing HWP non idealities #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskisner
approved these changes
Sep 2, 2020
src/toast/todmap/pointing.py
Outdated
| assuming that the detector is a linear polarizer followed by a total | ||
| power measurement. An optional dictionary of calibration factors may | ||
| be specified. Additional options include specifying a constant cross-polar | ||
| response (eps) and a rotating, perfect half-wave plate. The timestream |
There was a problem hiding this comment.
We should update the docstring for this operator since it is no longer a perfect half-wave plate.
|
Hello @giuspugl , it would be good to merge this today or tomorrow before the next point release. Hopefully it is not too much effort. |
tskisner
force-pushed
the
mueller_matrix
branch
from
971dec4
to
9b9d52c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First implementation of pointing operator encoding HWP non-idealities.
The weights have been estimated by combining several Mueller matrices as described in this report.