Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observe elevation limits in SSO scheduling #409

Merged
merged 3 commits into from
Jul 28, 2021
Merged

Observe elevation limits in SSO scheduling #409

merged 3 commits into from
Jul 28, 2021

Conversation

keskitalo
Copy link
Member

Companion PR for #408.

@keskitalo
Copy link
Member Author

Forgot this wasn't already merged. Should be non-controversial, addressing issues found in SO work.

@keskitalo keskitalo requested a review from tskisner July 28, 2021 15:51
tskisner
tskisner approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@tskisner tskisner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change. Does this also effectively port #376 changes? If so, I'll mark it off the 3.0 task list.

@keskitalo
Copy link
Member Author

This PR does not include the fixes from #376. I'll file another PR to handle those shortly.

@keskitalo keskitalo merged commit 3783b60 into toast3 Jul 28, 2021
@keskitalo keskitalo deleted the toast3_fix_sso_scheduling branch July 28, 2021 22:22
@keskitalo
Copy link
Member Author

@tskisner I misread. This PR does include fixes from #376. Please go ahead and cross it off the 3.0 task list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tskisner tskisner tskisner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keskitalo @tskisner