Use correct FOV when simulating atmosphere for the benchmark. #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nestordemeure
approved these changes
Oct 25, 2021
keskitalo
approved these changes
Oct 25, 2021
|
@keskitalo , the short answer is "no", but I suggest we fix that as part of #502, which will change all of that code anyway. |
… constructor was not the actual field of view.
…ences into the fake focalplane function.
…simulated time ranges agree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the proposed fix for the issue just discussed in our NESAP call. Will test on one failing scan on cori now.