-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{bio}[goolf/1.4.10] Cufflinks 1.3.0 (REVIEW) #1343
Conversation
Automatic reply from Jenkins: Can I test this? |
('zlib', '1.2.7'), | ||
] | ||
|
||
patches = ['Cufflinks_GCC-4.7.patch', 'cufflinks-1.3.0-ldflags.patch'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
each patch on a single line please, use %(version)s
rather than hardcoding 1.3.0
Jenkins: ok to test |
I renamed the patch since I'm pretty sure it is a general Cufflinks-1 issue (though there may never be another version...) |
Test PASSed. |
2 similar comments
Test PASSed. |
Test PASSed. |
Jenkins: test this please |
Test report by @boegel |
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Going in, thanks @rjeschmi! |
{bio}[goolf/1.4.10] Cufflinks 1.3.0 (REVIEW)
Some users haven't migrated to Cufflinks 2, so here is 1.3.0 (newest version 1). Somewhat old, but users want it.