refactor(anni): make placeholders more extensible

hpi-dhc · Jul 14, 2022 · d126fa6 · d126fa6
1 parent cb6a11f
commit d126fa6
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 12 deletions.
diff --git a/annotation-interface/components/bricks/BrickForm.tsx b/annotation-interface/components/bricks/BrickForm.tsx
@@ -14,10 +14,7 @@ import {
     translationsToArray,
     translationsToMap,
 } from '../../database/helpers/brick-translations';
-import {
-    allBrickPlaceholders,
-    medicationBrickPlaceholders,
-} from '../../database/helpers/resolve-bricks';
+import { placeHoldersForBrick } from '../../database/helpers/resolve-bricks';
 import {
     ITextBrick,
     ITextBrickTranslation,
@@ -126,11 +123,7 @@ const BrickForm = ({ usage, brick }: Props) => {
                             onChange={(text) =>
                                 updateTranslation(language, text)
                             }
-                            validPlaceholders={
-                                usage.startsWith('Drug')
-                                    ? [...medicationBrickPlaceholders]
-                                    : [...allBrickPlaceholders]
-                            }
+                            validPlaceholders={placeHoldersForBrick(usage)}
                         />
                     </div>
                 ))}

diff --git a/annotation-interface/database/helpers/resolve-bricks.ts b/annotation-interface/database/helpers/resolve-bricks.ts
@@ -1,4 +1,8 @@
-import { pharMeLanguage, SupportedLanguage } from '../../common/constants';
+import {
+    BrickUsage,
+    pharMeLanguage,
+    SupportedLanguage,
+} from '../../common/constants';
 import {
     ServerGuidelineOverview,
     ServerMedication,
@@ -9,12 +13,22 @@ import { ITextBrick } from '../models/TextBrick';
 import { translationsToMap } from './brick-translations';
 import { MongooseId, OptionalId } from './types';
 
-export const medicationBrickPlaceholders = ['drug-name'] as const;
-export const allBrickPlaceholders = [
+const medicationBrickPlaceholders = ['drug-name'] as const;
+const allBrickPlaceholders = [
     ...medicationBrickPlaceholders,
     'gene-symbol',
     'gene-result',
 ] as const;
+export const placeHoldersForBrick = (category: BrickUsage): string[] => {
+    switch (category) {
+        case 'Drug class':
+        case 'Drug indication':
+            return [...medicationBrickPlaceholders];
+        case 'Implication':
+        case 'Recommendation':
+            return [...allBrickPlaceholders];
+    }
+};
 type BrickPlaceholderValues = {
     [Property in typeof allBrickPlaceholders[number]]?: string;
 };