Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anni: Control Panel #364

Merged
merged 20 commits into from
Jun 22, 2022
Merged

anni: Control Panel #364

merged 20 commits into from
Jun 22, 2022

Conversation

jannis-baum
Copy link
Member

@jannis-baum jannis-baum commented Jun 17, 2022

Based on #361

Closes #340

Due to time constraints, we have decided to omit reviews for anni and only review changes to our existing core project. See below.

Changes on Annotation Server to review

  • implement endpoint to fetch/update only guidelines (and phenotypes)
    • fails if drugs aren't initialized
  • implement FetchDate to keep track of when drugs/guidelines have last been updated and corresponding API

@jannis-baum jannis-baum added T: Feature Type: New Features T: Refactor Type: Refactoring P: Annotation Server Project: Annotation Server P: Annotation Interface labels Jun 17, 2022
@jannis-baum jannis-baum self-assigned this Jun 17, 2022
@github-actions github-actions bot added the P: App Project: App label Jun 17, 2022
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #364 (86515a1) into main (47e1d56) will decrease coverage by 0.04%.
The diff coverage is 95.45%.

❗ Current head 86515a1 differs from pull request most recent head 864bc3c. Consider uploading reports for the commit 864bc3c to get more accurate results

@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
- Coverage   95.16%   95.11%   -0.05%     
==========================================
  Files          43       45       +2     
  Lines         786      819      +33     
  Branches       86       92       +6     
==========================================
+ Hits          748      779      +31     
- Misses         38       40       +2     
Flag Coverage Δ
annotation-server 94.31% <95.45%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n-server/src/guidelines/dtos/find-guideline.dto.ts 87.50% <87.50%> (ø)
annotation-server/src/common/api/params.ts 100.00% <100.00%> (ø)
...ion-server/src/guidelines/guidelines.controller.ts 100.00% <100.00%> (ø)
...tation-server/src/guidelines/guidelines.service.ts 95.09% <100.00%> (+0.09%) ⬆️
.../src/medications/dtos/find-medication-query-dto.ts 100.00% <100.00%> (ø)
...n-server/src/medications/medications.controller.ts 100.00% <100.00%> (ø)
...tion-server/src/medications/medications.service.ts 92.23% <100.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edafca4...864bc3c. Read the comment docs.

@jannis-baum jannis-baum force-pushed the issue/340-control-panel branch 7 times, most recently from 5e8621a to 0d0abaf Compare June 20, 2022 13:39
@jannis-baum jannis-baum force-pushed the issue/340-control-panel branch 3 times, most recently from df92408 to 9b12a58 Compare June 21, 2022 11:45
@jannis-baum jannis-baum force-pushed the issue/340-control-panel branch 8 times, most recently from 1cd1284 to e8fe121 Compare June 21, 2022 17:00
@jannis-baum jannis-baum marked this pull request as ready for review June 21, 2022 17:01
@jannis-baum jannis-baum force-pushed the issue/340-control-panel branch from e8fe121 to 091a6ea Compare June 21, 2022 17:02
@jannis-baum jannis-baum force-pushed the issue/340-control-panel branch from c8a2104 to 864bc3c Compare June 22, 2022 10:58
@jannis-baum jannis-baum merged commit fdcd4a5 into main Jun 22, 2022
@jannis-baum jannis-baum deleted the issue/340-control-panel branch June 22, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: Annotation Interface P: Annotation Server Project: Annotation Server P: App Project: App T: Feature Type: New Features T: Refactor Type: Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

anni: control panel
2 participants