Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPS-4474-evaluate-kubernetesproxy-Add options to generate passwords and not overwriting existing ones #59

Merged
merged 1 commit into from
Apr 25, 2023
Merged

OPS-4474-evaluate-kubernetesproxy-Add options to generate passwords and not overwriting existing ones #59

merged 1 commit into from
Apr 25, 2023

Conversation

YannickEvers
Copy link
Contributor

Description

Adds two options to the onepwd plugin:

  • Let 1password generate a password according to the specified rules (characters, length)
  • Overwrite option (default: true) to allow keeping already generated password by setting it to false

Small fix: Skip fields without label instead of crashing.

Links to Tickets or other pull requests

OPS-4474

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Screenshots of UI changes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@YannickEvers YannickEvers self-assigned this Apr 25, 2023
@YannickEvers YannickEvers requested a review from a team April 25, 2023 11:49
@aimee-889 aimee-889 changed the title Add options to generate passwords and not overwriting existing ones OPS-4474-evaluate-kubernetesproxy-Add options to generate passwords and not overwriting existing ones Apr 25, 2023
@YannickEvers YannickEvers merged commit d696160 into master Apr 25, 2023
@YannickEvers YannickEvers deleted the OPS-4474-evaluate-kubernetesproxy branch April 25, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aimee-889 aimee-889 aimee-889 approved these changes

Assignees

@YannickEvers YannickEvers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YannickEvers @aimee-889