-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-3844 - Vue3 upgrade with Webpack and Jest #2789
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uidp
added
WIP
someone is working on that
and removed
WIP
someone is working on that
labels
Nov 28, 2023
* using script setup in DateTimePicker components * adjust interaction handler * validate using vuelidate * change date prop to optional ISO String
…t-client into BC-3844-vue3-webpack
* Delete tiptap components * Refactor CK5 config * Use CK5 in news * Fix language switch
* fix i18 pre-compilation of typescript resources * add type definitions for translations
--------- Co-authored-by: odalys-dataport <odalys-dataport@users.noreply.github.com>
* remove code of old course share functionality * enable new course share feature with old feature flag
was removed by mistake on a resolving a git conflict
…t-client into BC-3844-vue3-webpack
* add role "menuitem" and "menu" for three-dot-menu of * room: course-, task- and lesson-menu * board: column- and card-menu * tasks: task-menu * fix headings for a11y in rooms --------- Co-authored-by: hoeppner-dataport <marcus.hoeppner@dataport.de>
…t-client into BC-3844-vue3-webpack
…t-client into BC-3844-vue3-webpack
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
hoeppner-dataport
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
To be able to use the latest features of Vue we want to upgrade the frontend to Vue 3. Despite many projects using Vite and Vitest with Vue3 it is still possible to stick to Webpack and Jest. Because the transition to new building and testing libraries (Vite and Vitest) would create a lot of effort we want to try to do upgrade to Vue 3 keeping the existing libraries.
Links to Ticket and related Pull-Requests
BC-3844
hpi-schul-cloud/dof_app_deploy#775
hpi-schul-cloud/schulcloud-server#4775
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging