Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-3844 - Vue3 upgrade with Webpack and Jest #2789

Merged
merged 504 commits into from
Feb 27, 2024
Merged

BC-3844 - Vue3 upgrade with Webpack and Jest #2789

merged 504 commits into from
Feb 27, 2024

Conversation

uidp
Copy link
Contributor

@uidp uidp commented Sep 6, 2023

Short Description

To be able to use the latest features of Vue we want to upgrade the frontend to Vue 3. Despite many projects using Vite and Vitest with Vue3 it is still possible to stick to Webpack and Jest. Because the transition to new building and testing libraries (Vite and Vitest) would create a lot of effort we want to try to do upgrade to Vue 3 keeping the existing libraries.

Links to Ticket and related Pull-Requests

BC-3844

hpi-schul-cloud/dof_app_deploy#775
hpi-schul-cloud/schulcloud-server#4775

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@uidp uidp added the WIP someone is working on that label Sep 6, 2023
@uidp uidp added WIP someone is working on that and removed WIP someone is working on that labels Nov 28, 2023
uidp and others added 7 commits February 21, 2024 14:31
* fix i18 pre-compilation of typescript resources

* add type definitions for translations
---------

Co-authored-by: odalys-dataport <odalys-dataport@users.noreply.github.com>
* remove code of old course share functionality
* enable new course share feature with old feature flag
@uidp uidp removed the WIP someone is working on that label Feb 23, 2024
Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
21.8% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@uidp uidp merged commit 8b2bb66 into main Feb 27, 2024
48 of 51 checks passed
@uidp uidp deleted the BC-3844-vue3-webpack branch February 27, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.