Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5096: adds docs regarding project structure #2793

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

OliverHappe
Copy link
Contributor

Short Description

I moved the docs from https://docs.dbildungscloud.de/pages/viewpage.action?pageId=220233889 into the project.

I also added a decision tree regarding a type and an matrix for allowed imports.

Links to Ticket and related Pull-Requests

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@pullapprove
Copy link

pullapprove bot commented Sep 7, 2023

Hey @OliverHappe, thanks for the PR! The review will start once
the tests, CI checks and PR requirements (see checklist in your PR) have passed.

@OliverHappe OliverHappe enabled auto-merge (squash) September 8, 2023 10:53
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@OliverHappe OliverHappe merged commit 50632e3 into main Sep 8, 2023
38 checks passed
@OliverHappe OliverHappe deleted the BC-5096-add-project-structure-docs branch September 8, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants