Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-2151 Partial course sync #3430

Merged
merged 8 commits into from
Nov 8, 2024
Merged

N21-2151 Partial course sync #3430

merged 8 commits into from
Nov 8, 2024

Conversation

MarvinOehlerkingCap
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Oct 25, 2024 •
edited by IgorCapCoder
Loading

Short Description

Links to Ticket and related Pull-Requests

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

This was referenced Oct 25, 2024
Merged
Merged
@MBergCap MBergCap mentioned this pull request Oct 29, 2024
Merged
1 task
IgorCapCoder
IgorCapCoder previously approved these changes Nov 4, 2024
View reviewed changes
MarvinOehlerkingCap and others added 3 commits November 6, 2024 09:57
@MarvinOehlerkingCap
Merge branch 'main' into N21-2151-partial-course-sync
64d32fa 
# Conflicts:
#	src/modules/feature/course-sync/StartExistingCourseSyncDialog.unit.ts
@sdinkov
update de translations
94a2be2
@IgorCapCoder
update locales
cdeabe9
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sdinkov sdinkov enabled auto-merge (squash) November 8, 2024 08:57
@sdinkov sdinkov merged commit 4061216 into main Nov 8, 2024
70 of 71 checks passed
@sdinkov sdinkov deleted the N21-2151-partial-course-sync branch November 8, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorCapCoder IgorCapCoder IgorCapCoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarvinOehlerkingCap @IgorCapCoder @sdinkov