Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THR-18: dev feature h5p editor #3277

Merged
merged 24 commits into from
Nov 16, 2023
Merged

Conversation

SteKrause
Copy link
Contributor

@SteKrause SteKrause commented Aug 21, 2023

Description

Links to Tickets or other pull requests

BC-5852
PR schulcloud-server: hpi-schul-cloud/schulcloud-server#4337
PR: nuxt-client: hpi-schul-cloud/nuxt-client#2748
PR dof_app_deploy: hpi-schul-cloud/dof_app_deploy#682

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

marode-cap and others added 3 commits July 31, 2023 14:42
static/scripts/topicEdit.js Dismissed Show resolved Hide resolved
@MajedAlaitwniCap MajedAlaitwniCap enabled auto-merge (squash) November 7, 2023 09:25
Copy link

sonarcloud bot commented Nov 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@casparneumann-cap casparneumann-cap merged commit b85ab89 into main Nov 16, 2023
41 of 42 checks passed
@casparneumann-cap casparneumann-cap deleted the THR-18-dev-feature-h5p-editor branch November 16, 2023 08:08
@casparneumann-cap casparneumann-cap restored the THR-18-dev-feature-h5p-editor branch November 16, 2023 08:08
@casparneumann-cap casparneumann-cap deleted the THR-18-dev-feature-h5p-editor branch November 20, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants