Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-5477 - Add optional chaining operator to course.times #3330

Merged
merged 4 commits into from
Oct 11, 2023
Merged

BC-5477 - Add optional chaining operator to course.times #3330

merged 4 commits into from
Oct 11, 2023

Conversation

bischofmax
Copy link
Contributor

@bischofmax bischofmax commented Oct 10, 2023 •
edited
Loading

Description

Links to Tickets or other pull requests

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@bischofmax bischofmax self-assigned this Oct 10, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@CeEv CeEv self-requested a review October 11, 2023 06:46
@bischofmax bischofmax merged commit c727d25 into main Oct 11, 2023
38 checks passed
@bischofmax bischofmax deleted the BC-5477-fix-course-until-date-bug branch October 11, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CeEv CeEv CeEv approved these changes

Assignees

@bischofmax bischofmax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bischofmax @CeEv