Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5850 - Team members can not be removed if they uploaded a file with whitespace #3356

Merged
merged 7 commits into from
Dec 19, 2023

Conversation

MartinSchuhmacher
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher commented Nov 27, 2023

Description

Currently it is not possible to remove a team member from that team if he/she uploaded/created a file in that team that contains a whitespace in the filename.

Why?

When loading the team members list, each members does contain a data-payload which also contains an array of files of that user (needed to display the this-users-files-will-also-get-deleted-info-popup). Files with whitespace break this encoded array and break the HTML, which prevents the userId from getting sent with the DELETE webrequest.

Links to Tickets or other pull requests

BC-5850

Changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Copy link

sonarcloud bot commented Dec 19, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MartinSchuhmacher MartinSchuhmacher merged commit 3a93b25 into main Dec 19, 2023
42 of 43 checks passed
@MartinSchuhmacher MartinSchuhmacher deleted the BC-5850-space-files branch December 19, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants