Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-6341 Revert Redis update #3395

Merged
merged 2 commits into from
Jan 23, 2024
Merged

BC-6341 Revert Redis update #3395

merged 2 commits into from
Jan 23, 2024

Conversation

dyedwiper
Copy link
Contributor

@dyedwiper dyedwiper commented Jan 23, 2024 •
edited
Loading

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-6341

hpi-schul-cloud/schulcloud-server#4712

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@dyedwiper dyedwiper mentioned this pull request Jan 23, 2024
Merged
3 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dyedwiper dyedwiper requested a review from Loki-Afro January 23, 2024 11:33
@dyedwiper dyedwiper merged commit 3d2679f into main Jan 23, 2024
41 of 44 checks passed
@dyedwiper dyedwiper deleted the BC-6341-revert-redis-update branch January 23, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loki-Afro Loki-Afro Loki-Afro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyedwiper @Loki-Afro