SC-9017; SC-9003 - adds to /me service school info and user permissions #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmissions This allows nuxt client to call only one endpoint instead of 3. This allows the other endpoints to be protected for direct access.
Closed
2 tasks
mergify
bot
added
the
WIP
Codecov Report
@@ Coverage Diff @@
## develop #2502 +/- ##
===========================================
- Coverage 76.16% 76.08% -0.08%
===========================================
Files 513 513
Lines 14176 14179 +3
===========================================
- Hits 10797 10788 -9
- Misses 3379 3391 +12
Continue to review full report at Codecov.
|
CeEv
requested changes
Jun 11, 2021
| @@ -33,9 +33,14 @@ class Service { | |||
| throw new Forbidden('Your access token is not valid.'); | |||
| } | |||
| user.accountId = params.account._id; | |||
|
|
|||
| const roles = await this.app.service('/roles/user').get(userId, params); | |||
There was a problem hiding this comment.
They go over the user services with populate roles and the users services resolve all permissions if the roles are populated.
CeEv
added
waiting for review
and removed
WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows nuxt client to call only one endpoint instead of 3.
This allows the other endpoints to be protected for direct access.
Links to Tickets or other pull requests
https://ticketsystem.hpi-schul-cloud.org/browse/SC-9017
hpi-schul-cloud/nuxt-client#1762
Changes
Datasecurity details on Confluence
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
Link to Definition of Done
More and detailed information on the definition of done can be found on Confluence