Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bc 4710 new tldraw manage #4352

Merged
merged 287 commits into from
Nov 28, 2023
Merged

Bc 4710 new tldraw manage #4352

merged 287 commits into from
Nov 28, 2023

Conversation

blazejpass
Copy link
Contributor

@blazejpass blazejpass commented Aug 24, 2023

Description

Add manage actions for tldraw in cards.

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Copy link
Contributor

@Metauriel Metauriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codewise fine, please look at pauls comments and switch the workflows back to main

blazejpass and others added 4 commits November 27, 2023 15:54
Co-authored-by: mamutmk5 <3045922+mamutmk5@users.noreply.github.com>
…pter service to separate module. Do devOps sugested name changes. Delete unnecessary sonar exclusions
Copy link

sonarcloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@blazejpass blazejpass merged commit 9f69eed into main Nov 28, 2023
47 of 48 checks passed
@blazejpass blazejpass deleted the BC-4710-new-tldraw-manage branch November 28, 2023 10:45
bergatco pushed a commit that referenced this pull request Dec 6, 2023
* Introduce tldraw to sc-server

---------

Co-authored-by: Błażej Szczepanowski <blazej1679@gmail.com>
Co-authored-by: davwas <daw.wasik@gmail.com>
Co-authored-by: Tomasz Wiaderek <Tomasz.Wiaderek@gca.pass-consulting.com>
Co-authored-by: wiaderwek <t.wiaderwek@gmail.com>
Co-authored-by: Thomas Feldtkeller <thomas.feldtkeller@dataport.de>
Co-authored-by: mamutmk5 <3045922+mamutmk5@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants