-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bc 4710 new tldraw manage #4352
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7aab343.
mamutmk5
requested changes
Nov 24, 2023
ansible/roles/schulcloud-server-core/templates/tldraw-deployment.yml.j2
Outdated
Show resolved
Hide resolved
Metauriel
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codewise fine, please look at pauls comments and switch the workflows back to main
…nt.yml.j2 Co-authored-by: mamutmk5 <3045922+mamutmk5@users.noreply.github.com>
…nt.yml.j2 Co-authored-by: mamutmk5 <3045922+mamutmk5@users.noreply.github.com>
Metauriel
requested changes
Nov 27, 2023
apps/server/src/modules/board/service/drawing-element-adapter.service.ts
Outdated
Show resolved
Hide resolved
mamutmk5
requested changes
Nov 27, 2023
Co-authored-by: mamutmk5 <3045922+mamutmk5@users.noreply.github.com>
…pter service to separate module. Do devOps sugested name changes. Delete unnecessary sonar exclusions
…C-4710-new-tldraw-manage
mamutmk5
requested changes
Nov 27, 2023
ansible/roles/schulcloud-server-core/templates/tldraw-server-svc.yml.j2
Outdated
Show resolved
Hide resolved
Metauriel
approved these changes
Nov 28, 2023
mamutmk5
approved these changes
Nov 28, 2023
Kudos, SonarCloud Quality Gate passed! |
2 tasks
bergatco
pushed a commit
that referenced
this pull request
Dec 6, 2023
* Introduce tldraw to sc-server --------- Co-authored-by: Błażej Szczepanowski <blazej1679@gmail.com> Co-authored-by: davwas <daw.wasik@gmail.com> Co-authored-by: Tomasz Wiaderek <Tomasz.Wiaderek@gca.pass-consulting.com> Co-authored-by: wiaderwek <t.wiaderwek@gmail.com> Co-authored-by: Thomas Feldtkeller <thomas.feldtkeller@dataport.de> Co-authored-by: mamutmk5 <3045922+mamutmk5@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add manage actions for tldraw in cards.
Links to Tickets or other pull requests
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:server
was executed in vue frontend and changes were tested and put in a PR with the same branch name.