Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N21-841 use user login migration #4356

Merged
merged 19 commits into from
Sep 26, 2023
Merged

Conversation

mrikallab
Copy link
Contributor

@mrikallab mrikallab commented Aug 25, 2023

Description

For the admin migration control section in vue client, the whole setMigration endpoint was desctructured. This PR fix the behavior of the close migration endpoint which is needed by the vue client.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/secure/RapidBoard.jspa?rapidView=162&view=detail&selectedIssue=N21-841

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the reason for this change

@mrikallab mrikallab dismissed MarvinOehlerkingCap’s stale review September 26, 2023 10:07

Igor will take over, because you are on vacation...

@mrikallab mrikallab requested review from IgorCapCoder and removed request for MarvinOehlerkingCap September 26, 2023 10:07
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@mrikallab mrikallab merged commit 7e6a281 into main Sep 26, 2023
42 of 43 checks passed
@mrikallab mrikallab deleted the N21-841-use-user-login-migration branch September 26, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants