BC-4343 - SJW - Disable Transfer Period in all instances #4372
Conversation
| @@ -40,7 +44,7 @@ appPromise | |||
| .updateMany( | |||
| { | |||
| federalState: { $in: federalStateIds }, | |||
| ldapSchoolIdentifier: { $exists: false }, | |||
| $or: [{ ldapSchoolIdentifier: { $exists: false } }, { ldapSchoolIdentifier: '' }], | |||
There was a problem hiding this comment.
we could also add here currentSchoolYear condition
currentYear: currentSchoolYearId._id instead of (or in addition to) currentYear: { $exists: true }
There was a problem hiding this comment.
Good point to do it similarly to the above situation for LDAP schools.
Why this is different here was my idea to basically adjust every school so no "remainers" are left behind.
For LDAP I wanted it to be more specific because there is more stuff that could go wrong.
|
Kudos, SonarCloud Quality Gate passed!
|
Description
Additional to database changes, this script is updated on server for future cases with correct syntax, once the scripts should run again on deployment. No further need for now.
Links to Tickets or other pull requests
BC-4343
Changes
Deployment
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.