Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N21 1235 vc permission in ctl bug fix #4376

Merged
merged 6 commits into from
Sep 4, 2023
Merged

Conversation

mrikallab
Copy link
Contributor

@mrikallab mrikallab commented Sep 1, 2023

Description

This PR add the start and join meeting permission to schooladmin and the join permission to teacher. This is required to use BBB if CTL Feature is enabled.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/N21-1235

Changes

START_MEETING permission addition to admin role NBC
JOIN_MEETING permission addition to admin role in NBC
JOIN_MEETING permission addition to teacher role in NBC

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@mrikallab mrikallab merged commit c869f7c into main Sep 4, 2023
42 of 43 checks passed
@mrikallab mrikallab deleted the N21-1235-join-meeting-bug-fix branch September 4, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants