Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-3961 move S3 client implementation to infra modules #4384

Merged
merged 10 commits into from
Sep 7, 2023
Merged

BC-3961 move S3 client implementation to infra modules #4384

merged 10 commits into from
Sep 7, 2023

Conversation

SevenWaysDP
Copy link
Contributor

@SevenWaysDP SevenWaysDP commented Sep 4, 2023 •
edited
Loading

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@SevenWaysDP @bergatco
Update apps/server/src/shared/infra/s3-client/README.md
ff79330 
Co-authored-by: bergatco <129839305+bergatco@users.noreply.github.com>
@SevenWaysDP SevenWaysDP requested a review from bergatco September 7, 2023 09:41
@SevenWaysDP SevenWaysDP enabled auto-merge (squash) September 7, 2023 09:44
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@SevenWaysDP SevenWaysDP merged commit 4d4041d into main Sep 7, 2023
42 of 43 checks passed
@SevenWaysDP SevenWaysDP deleted the BC-3961-fix-add-multiply-connecton branch September 7, 2023 09:58
NFriedo pushed a commit that referenced this pull request Sep 7, 2023
@SevenWaysDP @dyedwiper
@bergatco @NFriedo
BC-3961 move S3 client implementation to infra modules (#4384)
0f8ffc6 
---------

Co-authored-by: Max <53796487+dyedwiper@users.noreply.github.com>
Co-authored-by: bergatco <129839305+bergatco@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergatco bergatco bergatco approved these changes

@dyedwiper dyedwiper dyedwiper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SevenWaysDP @dyedwiper @bergatco